-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: optimize perf group cpi collection #1905
Conversation
Signed-off-by: bowen-intel <bowen.song@intel.com>
Signed-off-by: bowen-intel <bowen.song@intel.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1905 +/- ##
==========================================
+ Coverage 67.26% 67.58% +0.31%
==========================================
Files 410 413 +3
Lines 45662 46171 +509
==========================================
+ Hits 30715 31205 +490
+ Misses 12734 12703 -31
- Partials 2213 2263 +50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
the fix looks good, it will be better if there are some comparison about performance before/after the fix. also, dose PerfCollector has the same problem? @songtao98 |
environment![]() resultsudo perf trace -p `ps aux | grep koordlet | head -n 1 | awk '{print $2}'` -s -- sleep 360 # I just show one thread
ps -eLf | grep koordlet | wc -l old version![]() ![]() new version![]() ![]() |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2d34fc6
into
koordinator-sh:main
Signed-off-by: bowen-intel <bowen.song@intel.com>
Ⅰ. Describe what this PR does
By reusing
unix.PerfEventAttr
, we can decrease cgo calls, and remove goroutines to alleviate read pressure during CPI data collection.Ⅱ. Does this pull request fix one issue?
fixes #1884
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test